Only run -race -cover on ubuntu in the CI
#3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coverage information isn't used anywhere in the CI, so no need to have it for every OS. As for `-race`, there is no point in using it everywhere, one time should be enough, especially since it's taking a lot of time on Windows.
|
I don't see much difference when comparing with previous runs. Before:
After:
|
|
It seems that having both the downloading and the running tests in a single step made me erroneously deduce that the thing taking the most time was running the tests, and not downloading the dependencies. #3038 should fix the caching issue, and significantely reduce the time taken by the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage information isn't used anywhere in the CI, so no need to have it for every OS. As for
-race, there is no point in using it everywhere, one time should be enough, especially since it's taking a lot of time on Windows.