Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'ProgressBarBase' to 'ProgressBar' so it works on the (currently) latest PyTorch Lightning version #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtcalabro
Copy link

@dtcalabro dtcalabro commented Jun 27, 2023

I changed 'ProgressBarBase' to 'ProgressBar' because it changed in a PyTorch Lightning update. Based on their documentation, it appears it was changed after version 1.9.5, but I'm not positive. I do know that it was changed, so this should now work with the latest version of PyTorch Lightning at the time of writing.

@Vectorrent
Copy link
Contributor

Yes, this does work - but not alone. PR #216 implements additional modifications required for an upgrade to PL 2.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants