Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ELN10 NBDE related components #1054

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

sergio-correia
Copy link
Contributor

Replace http-parser[-devel] with llhttp[-devel]

Replace http-parser[-devel] with llhttp[-devel]

Signed-off-by: Sergio Correia <[email protected]>
@sgallagher sgallagher merged commit 3d5cc16 into minimization:main Jan 10, 2024
1 check passed
@yselkowitz
Copy link
Collaborator

For the record, the current consumers of http-parser in ELN have yet to be converted to llhttp:
libgit2: libgit2/libgit2#5828
tang: latchset/tang#136 (from OP)

"Someone" will need to do the work in libgit2 as well in order for us to be able to drop libgit2 from ELN (and RHEL 10). Thank you though for the advance warning on llhttp.

@sgallagher
Copy link
Collaborator

FYI, I've got a draft started for libgit2 here, but I'm not sure when I'll have the cycles to drive it to completion.

@sergio-correia
Copy link
Contributor Author

FYI, I've got a draft started for libgit2 here, but I'm not sure when I'll have the cycles to drive it to completion.

I forked your branch and did some minor fixes in this branch: https://github.com/sergio-correia/libgit2/tree/llhttp

I also changed it to try to use system libs first, initially try llhttp, then http-parser, and finally fall back to the bundled http-parser. I then added a container based on rawhide, to test llhttp. Not sure these + the other CI changes are correct, but maybe you can update your PR so we can check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants