-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console tries to communicate with SUBNET on startup #3456
Comments
@dvaldivia I think we should fix this for both AIStor and MinIO. Will we remove subnet support for MinIO when AIStor is released or will we keep supporting customers that want to stay on upstream MinIO? |
I did some investigation and I found that this only happens when not running in development mode. It looks like the license verification code tries to download the public key that is used for license key verification. It does fallback to a hardcoded offline key, if it cannot contact I think we should disable downloading Subnet's public verification key. The code always uses the hardcoded license key. If we rotate the private key for some reason, then new licenses should use a new release. We may want to allow overriding the hardcoded key, by specifying an environment variable that holds the base64 encoded public key. Users can set that environment variable if they insist on using an older version with a rotated license key. |
I noticed that MinIO also contacts |
@harshavardhana @dvaldivia How do you want to proceed with this? |
For For upstream, I think we can remove license related code in console. Might be better to confirm with @abperiasamy once. |
All new licenses will be issued for AIStor. I guess it would be fine to stop downloading an updated license verification key. I'll remove it from the code, so we'll keep the license check in, but without contacting subnet. Should we also set |
Expected: console should not talk to SUBNET on startup
Actual: console communicates with SUBNET on startup
How to reproduce?
ncat -l -p 443
127.0.0.1 subnet.min.io
to/etc/hosts
You will observe communication with
subnet.min.io
This does not happen if you start minio after setting
MINIO_BROWSER=off
The text was updated successfully, but these errors were encountered: