Always use offline public key for license verification #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
requested review from
anjalshireesh,
harshavardhana,
cesnietor and
dvaldivia
|
When this PR is merged, then MinIO console should be updated to use the new package version. |
ramondeklein
changed the title
harshavardhana
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MinIO console attempts to verify the license key. It needs the public key to verify the license signature and it downloads the key from subnet. MinIO is not supposed to contact external sites, unless explicitly asked to do so (minio/console#3456).
It now always uses the embedded public key (like it already did when subnet couldn't be reached). All license based products will be moving to AIStor eventually, so having the ability to deal with a rotating public key is less important.