Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bucket replication screen #3040

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

jinapurapu
Copy link
Contributor

@jinapurapu jinapurapu commented Sep 7, 2023

Also adds selector for replication of existing objects, as opposed to being enabled by default.

Screenshot 2024-01-24 at 1 33 47 PM

dvaldivia
dvaldivia previously approved these changes Sep 28, 2023
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to generate an error, form disappears and redirects you back to replication list page

2023-10-04 14 07 41

  • Submit button should be disabled until form is correct with the required fields

  • Need to add global page border as in Create Bucket page:

Screenshot 2023-10-04 at 2 07 15 p m

@jinapurapu jinapurapu force-pushed the add_bucket_replication_screen branch 2 times, most recently from 7b40de2 to ec06bc5 Compare October 6, 2023 21:40
Jillian Inapurapu added 4 commits January 24, 2024 11:14
WIP build issues

Style improvements, working better

Added selector for replicate existing objects

Removed unused imports

Updated swagger

WIP field validation, fixed error handling redirect behavior

Fixed position of formlayout

Validate fields

Added missing dependencies

disabled exhausitive deps

Moved url validation to external function

removed unused import
@jinapurapu jinapurapu force-pushed the add_bucket_replication_screen branch from b591556 to 6387a42 Compare January 24, 2024 21:24
@jinapurapu jinapurapu requested a review from bexsoft January 24, 2024 21:34
@harshavardhana harshavardhana merged commit 54c0b4b into minio:master Feb 26, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants