-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bucket replication screen #3040
Merged
harshavardhana
merged 8 commits into
minio:master
from
jinapurapu:add_bucket_replication_screen
Feb 26, 2024
Merged
Add bucket replication screen #3040
harshavardhana
merged 8 commits into
minio:master
from
jinapurapu:add_bucket_replication_screen
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
pjuarezd,
cniackz,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
bexsoft and
dilverse
September 7, 2023 23:05
dvaldivia
previously approved these changes
Sep 28, 2023
bexsoft
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jinapurapu
force-pushed
the
add_bucket_replication_screen
branch
2 times, most recently
from
October 6, 2023 21:40
7b40de2
to
ec06bc5
Compare
bexsoft
requested changes
Oct 31, 2023
portal-ui/src/screens/Console/Buckets/BucketDetails/AddBucketReplication.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/BucketDetails/AddBucketReplication.tsx
Outdated
Show resolved
Hide resolved
WIP build issues Style improvements, working better Added selector for replicate existing objects Removed unused imports Updated swagger WIP field validation, fixed error handling redirect behavior Fixed position of formlayout Validate fields Added missing dependencies disabled exhausitive deps Moved url validation to external function removed unused import
jinapurapu
force-pushed
the
add_bucket_replication_screen
branch
from
January 24, 2024 21:24
b591556
to
6387a42
Compare
dvaldivia
approved these changes
Feb 26, 2024
harshavardhana
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds selector for replication of existing objects, as opposed to being enabled by default.