-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Browser Refactor #3066
Object Browser Refactor #3066
Conversation
After creating a path, "Loading" remains, drag and drop upload doesn't work. Screen.Recording.2023-10-02.at.11.09.53.AM.mov |
Clicking arrow icon to invert object list order causes "Loading" to hang: Screen.Recording.2023-10-02.at.1.40.10.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested different scenarios with paths, tracing, anonymous buckets, deleting and adding multiple objects. All seems great.! Just left few comments.
74284c7
to
ac76bd7
Compare
Fixed |
- Refactored navigation to be handled only with URL - Refactored & simplified websocket - Updated components to use mds - Fixed an issue with Anonymous access and file selection - Fixed an issue with anonymous access and download selection click - Fixed an issue with object details selection on root path from a bucket - Simplified reducer Signed-off-by: Benjamin Perez <[email protected]>
- Refactored navigation to be handled only with URL - Refactored & simplified websocket - Updated components to use mds - Fixed an issue with Anonymous access and file selection - Fixed an issue with anonymous access and download selection click - Fixed an issue with object details selection on root path from a bucket - Simplified reducer Signed-off-by: Benjamin Perez <[email protected]>
- Refactored navigation to be handled only with URL - Refactored & simplified websocket - Updated components to use mds - Fixed an issue with Anonymous access and file selection - Fixed an issue with anonymous access and download selection click - Fixed an issue with object details selection on root path from a bucket - Simplified reducer Signed-off-by: Benjamin Perez <[email protected]>
fixes #3001
What does this do?
Simplified the Object Browser code by changing the location of Websockets to be a middleware as well as simplifying the logic to handle the object browser paths