Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.7.4 #3472

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Release v1.7.4 #3472

merged 1 commit into from
Nov 26, 2024

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Nov 12, 2024

No description provided.

@bexsoft bexsoft self-assigned this Nov 12, 2024
@bexsoft bexsoft marked this pull request as ready for review November 12, 2024 01:44
reivaj05
reivaj05 previously approved these changes Nov 12, 2024
View reviewed changes
@donatello
Copy link
Member

Do we merge with the CI failure?

@ramondeklein
Copy link
Collaborator

Do we merge with the CI failure?

I don’t think we should. Why do we need a new console release at this time?

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 12, 2024 •
edited
Loading

Do we merge with the CI failure?

Yes, This PDF issue is not a real failure, PDF is rendered correctly in the UI Locally I see an error related to pdf worker library required for this and testcafe. This needs further investigation

@bexsoft bexsoft marked this pull request as draft November 20, 2024 19:57
@bexsoft bexsoft requested review from reivaj05 and bayasdev November 20, 2024 20:02
bayasdev
bayasdev previously approved these changes Nov 20, 2024
View reviewed changes
@bexsoft bexsoft dismissed stale reviews from bayasdev and reivaj05 via b0d3d56 November 20, 2024 20:09
cesnietor
cesnietor reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Changelog.md

ramondeklein
ramondeklein reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.

For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 21, 2024

@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.

For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.

Yes, @ramondeklein, all files are updated with the latest master change. we use a release script to generate these files, maybe could be related

ramondeklein
ramondeklein previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIth the removal of functionality, this isn't a patch. It should at least be named v1.8.0. But I don't think version number is actually being used -outside MinIO-, so I guess it's fine...

@feorlen
Copy link

feorlen commented Nov 22, 2024 •
edited
Loading

@bexsoft corresponding docs ready to merge
minio/docs#1373

@feorlen feorlen mentioned this pull request Nov 22, 2024
Merged
Release v1.7.4
6f8bb9f 
Signed-off-by: Benjamin Perez <[email protected]>
@bexsoft bexsoft marked this pull request as ready for review November 26, 2024 18:46
@bexsoft bexsoft merged commit 9a3063b into minio:master Nov 26, 2024
28 of 30 checks passed
@bexsoft bexsoft deleted the release-v1.7.4 branch November 26, 2024 20:49
feorlen added a commit to minio/docs that referenced this pull request Nov 26, 2024
@feorlen @Bradamant3
Remove references to various ex MinIO Console features (#1373)
48feb40 
UI for the following has been removed from MinIO Console:

- Lifecycle and tiering
- Site replication
- SUBNET

Waiting for merge of minio/console#3472

Staged:

http://192.241.195.202:9000/staging/DOCS-1372/linux/administration/minio-console.html

http://192.241.195.202:9000/staging/DOCS-1372/linux/administration/bucket-replication.html

http://192.241.195.202:9000/staging/DOCS-1372/linux/operations/install-deploy-manage/multi-site-replication.html#id4


fixes #1372

---------

Co-authored-by: Jennifer Rondeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayasdev bayasdev bayasdev approved these changes

@cesnietor cesnietor cesnietor approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@donatello donatello Awaiting requested review from donatello

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@adriangitvitz adriangitvitz Awaiting requested review from adriangitvitz

@JoelRuizRojas JoelRuizRojas Awaiting requested review from JoelRuizRojas

@ramondeklein ramondeklein Awaiting requested review from ramondeklein

Assignees

@bexsoft bexsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bexsoft @donatello @ramondeklein @feorlen @reivaj05 @cesnietor @bayasdev