fix: do not allow removing/changing the reserved labels #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
previously approved these changes
Sep 11, 2024
balamurugana
requested changes
Sep 11, 2024
Praveenrajmani
force-pushed
the
reserved-label-fix
branch
from
938ed07
to
1d6df31
Compare
also, show only custom labels in `kubectl directpv list drives --show-labels` and `kubectl directpv list volumes --show-labels`
Praveenrajmani
force-pushed
the
reserved-label-fix
branch
from
1d6df31
to
b2b6ecc
Compare
balamurugana
approved these changes
Sep 11, 2024
prakashsvmx
approved these changes
Sep 11, 2024
|
Please submit this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not allow the reserved labels to be removed or edited as this will affect the directpv operations.
also, show only custom labels in
kubectl directpv list drives --show-labelsandkubectl directpv list volumes --show-labels