Adds recommended metrics to Prometheus procedure #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feorlen
reviewed
Mar 4, 2024
source/operations/monitoring/collect-minio-metrics-using-prometheus.rst
Outdated
Show resolved
Hide resolved
|
"Recommended alerts" presumably means these are the metrics we think are important enough to create alerts for. Leaving as an exercise for the reader what thresholds constitute something worth alerting on. If there is more we want to say about that, perhaps a new section would be useful. If not, maybe name the tab something other than alerts. "Recommended metrics"? In the sense of "We think these are important, you can decide how to monitor them." |
|
Retitled the tab for now. Will still consider a separate section, perhaps in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1135
To consider:
I added the tabs as part of step 3 of the procedure, but we might want to consider having a recommended alerts section separate from the procedure, perhaps above the "Dashboards" heading. Let me know your thoughts.
Staged: