Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault: reset token TTL to 0 when renewing token #501

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

aead
Copy link
Member

@aead aead commented Jan 13, 2025

This commit resets the token TTL to zero once we start another re-authentication attempt. The reason is that if we fail to re-authenticate, we should not wait again for 80% of the prev. token TTL but instead re-authenticate right away.

@aead aead requested a review from ramondeklein January 13, 2025 13:12
This commit resets the token TTL to zero once we start
another re-authentication attempt. The reason is that if
we fail to re-authenticate, we should not wait again for 80%
of the prev. token TTL but instead re-authenticate right
away.

Signed-off-by: Andreas Auernhammer <[email protected]>
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aead aead merged commit be730c6 into master Jan 13, 2025
8 checks passed
@aead aead deleted the vault-ttl-reset branch January 13, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants