Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kms: add support for capturing performace profiles #17

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

aead
Copy link
Member

@aead aead commented Apr 29, 2024

This commit adds support for capturing perf. profiles at a KMS server. Now, a client can start a performace profile via:

client.StartProfiling(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})

After some time, the client can either inspect that status of an ongoing profiling via:

client.ProfileStatus(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})

or stop the profiling and download the results:

client.StopProfiling(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})

The result of a profile is a stream of pprof files packed into a TAR archive.

@aead aead requested a review from allanrogerr April 29, 2024 21:21
@aead aead force-pushed the pprof branch 2 times, most recently from 992b8b5 to f90ebb7 Compare April 29, 2024 21:53
This commit adds support for capturing perf. profiles
at a KMS server. Now, a client can start a performace
profile via:
```
client.StartProfiling(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})
```

After some time, the client can either inspect that
status of an ongoing profiling via:
```
client.ProfileStatus(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})
```

or stop the profiling and download the results:
```
client.StopProfiling(ctx, &ProfileRequest{
   Host: "192.168.188.110:7373",
   ...
})
```

The result of a profile is a stream of pprof files
packed into a TAR archive.

Signed-off-by: Andreas Auernhammer <[email protected]>
Copy link

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 9a4be97 into main Apr 30, 2024
5 checks passed
@dvaldivia dvaldivia deleted the pprof branch April 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants