fix: mirror --summary should work like -q #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
requested review from
harshavardhana,
klauspost,
zveinn,
shtripat and
vadmeste
jiuker
force-pushed
the
fix_mirror_summary_work_as_quiet
branch
from
22e3ed4 to
21322a6
Compare
fix: --summary should work like -q
jiuker
force-pushed
the
fix_mirror_summary_work_as_quiet
branch
from
21322a6 to
641a689
Compare
klauspost
approved these changes
May 8, 2024
klauspost
requested changes
May 8, 2024
Yes. See the test case. jiuker@MacBook-Pro mc % ./mc mirror --overwrite --retry --summary --skip-errors /Users/jiuker/workspace/go/src/pkg/mc /Users/jiuker/workspace/go/src/minio/stage/issueBucket
.../go/src/pkg/mc/testdata/localhost.crt: 68.04 MiB / 68.04 MiB ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 64.99 MiB/s 1s
jiuker@MacBook-Pro mc % ./mc mirror --overwrite --retry --summary --skip-errors /Users/jiuker/workspace/go/src/pkg/mc /Users/jiuker/workspace/go/src/minio/stage/issueBucket -q
Total: 0 B, Transferred: 0 B, Speed: 0 B/sjiuker@MacBook-Pro mc % ./mc mirror --overwrite --retry --summary --skip-errors /Users/jiuker/workspace/go/src/pkg/mc /Users/jiuker/workspace/go/src/minio/stage/issueBucket -q
Total: 68.13 MiB, Transferred: 68.13 MiB, Speed: 59.86 MiB/sThe second one show zero for nothing to copy with the same commad. It will show the correct size if that have objects to copy really. |
klauspost
approved these changes
May 10, 2024
harshavardhana
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
fix: mirror --summary should work like -q
Or user must use
--summarywith-qto avoid incorrectProgressStatus.Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)