Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS v3.0.0] Migrated mds to use emotion library #1045

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Oct 21, 2024

MDS v3.0.0

What does this do?

  • Migration to emotion library
  • Fixed styles for components
  • Simplified Themes & direct use of colors
  • Creation of useMDSTheme hook to be able to use the same themes as in mds in your applicaton
  • Implementation of styled export from mds to allow custom component creation

Breaking Changes

  • Removal of obsolete components (ActionsList, InformativeMessage, MainContainer, Menu, Pill)
  • Renamed components to match specification (CommentBox => TextArea, ReadBox => CodeSnippet, Switch => Toggle)
  • Props in some components got renamed

@bexsoft bexsoft self-assigned this Oct 21, 2024
@bexsoft bexsoft marked this pull request as draft October 21, 2024 07:52
@bexsoft bexsoft changed the title [MDS v3]Migrated mds to use emotion Library [MDS v3][DO NOT MERGE THIS YET]Migrated mds to use emotion Library Oct 21, 2024
@bexsoft bexsoft force-pushed the emotion-migration branch 11 times, most recently from 5ac9e7a to 9ba85d6 Compare October 22, 2024 05:25
- Migration to emotion library
- Fixed styles for compoents
- Simplified Themes & direct use of colors
- Removal of obsolete components (ActionsList, InformativeMessage, MainContainer, Menu, Pill)
- Renamed components to match specification (CommentBox => TextArea, ReadBox => CodeSnippet, Switch => Toggle)

Signed-off-by: Benjamin Perez <[email protected]>
@bexsoft bexsoft changed the title [MDS v3][DO NOT MERGE THIS YET]Migrated mds to use emotion Library [MDS v3.0.0] Migrated mds to use emotion library Oct 22, 2024
@bexsoft bexsoft marked this pull request as ready for review October 22, 2024 05:32
@bexsoft bexsoft requested review from sen-io and SSushmitha8 October 22, 2024 05:33
@ramondeklein
Copy link

So glad, I wasn't added as one of the reviewers of this 5.000+ file PR 😄

@bexsoft bexsoft merged commit f5587b9 into minio:master Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants