Removed font files import from mds #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
pjuarezd,
ramondeklein,
cniackz,
reivaj05,
cesnietor,
rushenn,
dvaldivia,
prakashsvmx,
kaankabalak,
adriangitvitz,
bayasdev,
jinapurapu,
oscarocastellanos and
sen-io
There is an inconsistence between libraries as we are importing the default fonts in the applications by using GlobalStyles. The disadvantage of this is that there is a flickering between renders in the initial load until the fonts get loaded. This PR removes de default font imports by levering this to the application where you are going to use mds. Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
remove-font-support
branch
from
763adf4 to
9bf0175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
There is an inconsistence between libraries as we are importing the default fonts in the applications by using GlobalStyles. The disadvantage of this is that there is a flickering between renders in the initial load until the fonts get loaded.
This PR removes de default font imports by levering this to the application where you are going to use mds.