Method MinioClientFactory.CreatClient always creates a client with SSL true, even if you configure it as false;

[voryba]

Method MinioClientFactory.CreatClient always creates a client with SSL true, even if you configure it as false;

Expected Behavior

public static IMinioClient WithSSL(this IMinioClient minioClient, bool secure = true)
{
    if (minioClient is null) throw new ArgumentNullException(nameof(minioClient));

    if (secure)
    {
        minioClient.Config.Secure = true;
        if (string.IsNullOrEmpty(minioClient.Config.BaseUrl))
            return minioClient;
        //var secureUrl = RequestUtil.MakeTargetURL(minioClient.BaseUrl, minioClient.Secure);
    }
    else
    {
        minioClient.Config.Secure = false;
     }
    return minioClient;
}

Current Behavior

    var client = new MinioClient()
        .WithSSL(); --> defaut value is true

// after this client will be configured with action:
configureClient(client);

// In the method there is no action for the false case. So when you created client before, its already created with SSL true

public static IMinioClient WithSSL(this IMinioClient minioClient, bool secure = true)
{
    if (minioClient is null) throw new ArgumentNullException(nameof(minioClient));

    if (secure)
    {
        minioClient.Config.Secure = true;
        if (string.IsNullOrEmpty(minioClient.Config.BaseUrl))
            return minioClient;
        //var secureUrl = RequestUtil.MakeTargetURL(minioClient.BaseUrl, minioClient.Secure);
    }
    -- NO ACTION FOR FALSE CASE;
    return minioClient;
}

[balamurugana]

We do not ship MinioClientFactory. You would need to open/report this issue to respective project.

[ebozduman]

Looking into it...

[ebozduman]

This issue is fixed in the upcoming PR #844.
It is currently in code review and it'll be merged as soon as the code review is complete and approved.

[ebozduman]

@voryba, @fabientrissie, @S3V3N-11

PR #844 is merged.

Could you please test it and close this issue if it passes your test?

[ebozduman]

Closing as fixed.
Please reopen if you disagree.