Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic AWS endpoint selection #1221

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Automatic AWS endpoint selection #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 0 additions & 79 deletions Minio/AWSS3Endpoints.cs
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions Minio/Helper/RequestUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ internal static Uri MakeTargetURL(string endPoint, bool secure, string bucketNam
{
// For Amazon S3 endpoint, try to fetch location based endpoint.
var host = endPoint;
if (S3utils.IsAmazonEndPoint(endPoint))
// Fetch new host based on the bucket location.
host = AWSS3Endpoints.Endpoint(region);
if (S3utils.IsAmazonEndPoint(endPoint) && !string.IsNullOrEmpty(region))
host = $"s3.{region}.amazonaws.com";

if (!usePathStyle)
{
Expand Down
Loading