Fix support of webassembly #911
Conversation
|
@Chang228, |
There was a problem hiding this comment.
@Chang228,
Here are my review changes as a git diff output:
$ git diff Minio/DataModel/Result/ResponseResult.cs
diff --git a/Minio/DataModel/Result/ResponseResult.cs b/Minio/DataModel/Result/ResponseResult.cs
index f4ad4c3..5b4c062 100644
--- a/Minio/DataModel/Result/ResponseResult.cs
+++ b/Minio/DataModel/Result/ResponseResult.cs
@@ -31,7 +31,7 @@ public ResponseResult(HttpRequestMessage request, HttpResponseMessage response,
{
Request = request;
Response = response;
- ContentStream = stream;
+ ContentStream = stream ?? Task.Run(async () => await (Response?.Content.ReadAsStreamAsync()).ConfigureAwait(false)).Result;
}
public ResponseResult(HttpRequestMessage request, Exception exception)
@@ -56,7 +56,7 @@ public HttpStatusCode StatusCode
}
}
- public Stream ContentStream { get; }//if (Response is null) return null;//return stream ??= Response.Content.ReadAsStream();
+ public Stream ContentStream { get; }
public ReadOnlyMemory<byte> ContentBytes
{
| var statusCode = response.StatusCode; | ||
| var memoryStream = new MemoryStream(); | ||
| if (statusCode == HttpStatusCode.OK) | ||
| { | ||
| var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false); | ||
| await stream.CopyToAsync(memoryStream).ConfigureAwait(false); | ||
| memoryStream.Position = 0; | ||
| } | ||
|
|
||
| responseResult = new ResponseResult(request, response, memoryStream); |
There was a problem hiding this comment.
Because of the previous review comments, this part needs to be cleaned up as responseResult has the ContentStream already set up.
There was a problem hiding this comment.
You should also run dotnet regitlint for formatting problems.
| @@ -202,14 +202,69 @@ private ReadOnlySpan<byte> GenerateSigningKey(string region, DateTime signingDat | |||
| /// <param name="content">Bytes to be hmac computed</param> | |||
| /// <returns>Computed hmac of input content</returns> | |||
| private ReadOnlySpan<byte> SignHmac(ReadOnlySpan<byte> key, ReadOnlySpan<byte> content) | |||
| { | |||
| return ComputeHmac256(key.ToArray(), content.ToArray()); | |||
There was a problem hiding this comment.
I think this code is the cause of the Functional test failure caught during the build tests.
You need to debug the code and resolve the issue.
When I reverted this change and run the Functional tests with the code suggested in the previous review comments, Functional tests ran successfully.
Webassembly has no support HMAC calculation and HttpResponseMessage sync stream,
use code to implement HMAC SHA256 calculation