Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update s3-endpoints.go with ISO endpoints #2053

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update s3-endpoints.go with ISO endpoints #2053

merged 2 commits into from
Jan 27, 2025

Conversation

vnzongzna
Copy link
Contributor

Fixes #2049

klauspost
klauspost requested changes Jan 21, 2025
View reviewed changes
s3-endpoints.go Show resolved Hide resolved
klauspost
klauspost approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't validate these, but I suppose adding them will not hurt.

@vnzongzna
Copy link
Contributor Author

vnzongzna commented Jan 26, 2025 •
edited
Loading

Apologies to ping on weekend, but can we merge this, I'll like to use this updated module in

@harshavardhana harshavardhana merged commit 41664c2 into minio:master Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ISO endpoints
3 participants
@vnzongzna @harshavardhana @klauspost