Skip to content

Refactor entire code for v9.0.0 #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor entire code for v9.0.0 #1621

wants to merge 1 commit into from

Conversation

@balamurugana
Copy link
Member

@balamurugana balamurugana commented Feb 4, 2025 •
edited
Loading

  • Move dependent classes as subclasses in messages
  • PutObject supports parallel uploads and checksum
  • Examples are updated
  • Dependencies are upgraded
  • Remove all deprecated methods

@balamurugana balamurugana marked this pull request as draft February 4, 2025 12:09
@balamurugana balamurugana force-pushed the Refactor-messages-by-subclasses branch 27 times, most recently from c7bd699 to e48331a Compare February 17, 2025 13:00
@balamurugana balamurugana force-pushed the Refactor-messages-by-subclasses branch 2 times, most recently from 9f9d9fa to d236c38 Compare February 18, 2025 13:43
@balamurugana balamurugana force-pushed the Refactor-messages-by-subclasses branch 8 times, most recently from 0afc13f to e064a53 Compare September 28, 2025 08:11
This was referenced Sep 28, 2025
Closed
Closed
@balamurugana balamurugana marked this pull request as ready for review September 28, 2025 08:58
@nagashreem
Copy link

nagashreem commented Oct 8, 2025

@harshavardhana

@balamurugana is this ready to be reviewed?
This PR is complete. As it a breaking change, we would need to make next v8.5.x release, so that it fixes in the v8.5.x

@harshavardhana is the release done? @balamurugana is there anything else pending here other than the reviews?
@Praveenrajmani @kanagarajkm can we please get some reviews here?

shtripat
shtripat requested changes Oct 8, 2025
View reviewed changes
@balamurugana
Copy link
Member Author

balamurugana commented Oct 8, 2025

@harshavardhana

@balamurugana is this ready to be reviewed?
This PR is complete. As it a breaking change, we would need to make next v8.5.x release, so that it fixes in the v8.5.x

@harshavardhana is the release done? @balamurugana is there anything else pending here other than the reviews? @Praveenrajmani @kanagarajkm can we please get some reviews here?

@nagashreem Other than review, nothing is pending

@balamurugana balamurugana force-pushed the Refactor-messages-by-subclasses branch 2 times, most recently from 93cfd5b to 30b61d6 Compare October 16, 2025 03:34
@balamurugana balamurugana requested a review from shtripat October 16, 2025 03:38
shtripat
shtripat previously approved these changes Oct 16, 2025
View reviewed changes
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@balamurugana
Refactor entire code for v9.0.0
4dd4a48 
* Move dependent classes as subclasses in messages
* PutObject supports parallel uploads and checksum
* Examples are updated
* Dependencies are upgraded
* Remove all deprecated methods
* Add appendObject API

Signed-off-by: Bala.FA <[email protected]>
@balamurugana balamurugana force-pushed the Refactor-messages-by-subclasses branch from 30b61d6 to 4dd4a48 Compare October 27, 2025 14:45
@balamurugana balamurugana mentioned this pull request Nov 3, 2025
Closed
@harshavardhana
Copy link
Member

harshavardhana commented Nov 5, 2025

PTAL @shtripat @kanagarajkm

shtripat
shtripat approved these changes Nov 5, 2025
View reviewed changes
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shtripat shtripat shtripat approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@kannappanr kannappanr Awaiting requested review from kannappanr

@Praveenrajmani Praveenrajmani Awaiting requested review from Praveenrajmani

@kanagarajkm kanagarajkm Awaiting requested review from kanagarajkm

At least 2 approving reviews are required to merge this pull request.

Assignees

@balamurugana balamurugana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@balamurugana @harshavardhana @nagashreem @shtripat