Fix IMDSv2 URL when fetching credentials #1464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setu4993
commented
Dec 6, 2024
Comment on lines
-511
to
-517
| urlunsplit( | ||
| url_replace( | ||
| urlsplit(url), | ||
| path="/latest/meta-data/iam/security-credentials/", | ||
| ), | ||
| ), | ||
| headers=headers, |
There was a problem hiding this comment.
This seemed unnecessary so I simplified it with L507.
| ) | ||
| role_names = res.data.decode("utf-8").split("\n") | ||
| if not role_names: | ||
| raise ValueError(f"no IAM roles attached to EC2 service {url}") | ||
| url += "/" + role_names[0].strip("\r") | ||
| url += role_names[0].strip("\r") |
There was a problem hiding this comment.
The role gets added at the end of the URL that was updated on L507.
There was a problem hiding this comment.
This is also in the Go implementation here: https://github.com/minio/minio-go/blob/e337e77c06bbf8a65247fb018e59c1263e4d86e1/pkg/credentials/iam_aws.go#L400-L402
We just missed it in the revisions in #1437.
|
@balamurugana : Fixes IMDSv2 that didn't work correctly. Only found out today. |
|
I am closing on behalf of #1465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed 1 change in the final version of #1437 where the URL to fetch the endpoint must include
"/latest/meta-data/iam/security-credentials/"before the role name. This adds that back.Closes #1459.