Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IamAwsProvider: fix url with role name #1465

Merged
merged 2 commits into from
Dec 18, 2024
Merged

IamAwsProvider: fix url with role name #1465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15d7fa0
IamAwsProvider: fix url with role name
balamurugana Dec 6, 2024
b21c693
Merge branch 'master' into fix-issue-1459
harshavardhana Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions minio/credentials/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,21 +505,17 @@ def retrieve(self) -> Credentials:
headers = {"X-aws-ec2-metadata-token": token} if token else None

# Get role name
res = _urlopen(
self._http_client,
"GET",
urlunsplit(
url_replace(
urlsplit(url),
path="/latest/meta-data/iam/security-credentials/",
),
url = urlunsplit(
url_replace(
urlsplit(url),
path="/latest/meta-data/iam/security-credentials/",
),
headers=headers,
)
res = _urlopen(self._http_client, "GET", url, headers=headers)
role_names = res.data.decode("utf-8").split("\n")
if not role_names:
raise ValueError(f"no IAM roles attached to EC2 service {url}")
url += "/" + role_names[0].strip("\r")
url += role_names[0].strip("\r")
if not url:
raise ValueError("url is empty; this should not happen")
self._credentials = self.fetch(url, headers=headers)
Expand Down
Loading