Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple trust certs in cert file #102

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

donatello
Copy link
Member

The .ssl_cert_file() option now can read files with multiple certificate to trust. This is useful when using a single client instance to access many minio servers.

HJLebbink
HJLebbink previously approved these changes Oct 25, 2024
Copy link
Member

@HJLebbink HJLebbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as advertised.

The `.ssl_cert_file()` option now can read files with multiple
certificate to trust. This is useful when using a single client instance
to access many minio servers.
Copy link
Member

@HJLebbink HJLebbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems you reverted almost all your changes?

@donatello
Copy link
Member Author

LGTM, but it seems you reverted almost all your changes?

No this looks right. We are adding all the certs from the file now.

@donatello donatello merged commit 903acae into minio:master Oct 28, 2024
1 check passed
@donatello donatello deleted the multi-certs branch October 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants