Fix list objects xml parsing bug and improve perf. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains 1 commit made on top of #58 |
donatello
force-pushed
the
fix-listing
branch
from
521ebe9 to
7912303
Compare
krisis
previously approved these changes
Oct 26, 2023
For list-object-versions there was a bug that would return delete markers after all versions of an object. The server response contains the order of versions and delete markers according to recency and the list objects client call should preserve this. This is fixed in this change. XML parsing was using the `take_child` call, that mutates a vector removing an element in it. For a response containing N items, using take_child on item, causes the XML parsing cost to be O(N^2) (so 1 million operations for a 1000 item list) - this change makes the parsing cost linear.
balamurugana
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For list-object-versions there was a bug that would return delete
markers after all versions of an object. The server response contains
the order of versions and delete markers according to recency and the
list objects client call should preserve this. This is fixed in this
change.
XML parsing was using the
take_childcall, that mutates a vectorremoving an element in it. For a response containing N items, using
take_child on item, causes the XML parsing cost to be O(N^2) (so 1
million operations for a 1000 item list) - this change makes the parsing
cost linear.