Skip to content

Commit

Permalink
fix: release build issues
Browse files Browse the repository at this point in the history
- remove incorrect 'go mod tidy'
- remove unnecessary 'go mod download'
  • Loading branch information
harshavardhana committed Jul 17, 2024
1 parent fc934fd commit 39d57f3
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 20 deletions.
2 changes: 0 additions & 2 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ release:
before:
hooks:
- make clean
- go mod tidy -compat=1.21.8
- go mod download

builds:
- goos:
Expand Down
14 changes: 4 additions & 10 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,8 @@ rolling restart for a MinIO Tenant, for example when the MinIO Operator is upgra

This release introduces a readiness probe to prevent kubernetes from routing traffic to a MinIO pod that is not ready

> ⚠️ Upgrading to v6.0.0 will cause all pods to restart upon upgrade.
v6.0.1
---

This release includes improvements to reduce the number of restarts to MinIO including when changes to environment
variables happen, the operator will perform an in-place update to the MinIO pods without restarting them.

> ⚠️ Upgrading to v6.0.1 will cause all pods to restart upon upgrade due to new sidecar image.
> [!IMPORTANT]
> Upgrading to v6.0.0 will cause all pods to restart upon upgrade.
v5.0.0
---
Expand All @@ -39,7 +32,8 @@ left running as stand-alone
deployments/statefulset with no connection to the Tenant CR itself, this means that if the Tenant CR is deleted, this
will not cascade to these deployments.

> ⚠️ It is recommended to create a yaml file to manage these deployments subsequently.
> [!IMPORTANT]
> It is recommended to create a yaml file to manage these deployments subsequently.
To back up these deployments:

Expand Down
2 changes: 0 additions & 2 deletions pkg/build-constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ var (
CommitID = "(dev)"
// ShortCommitID - first 12 characters from CommitID.
ShortCommitID = "(dev)"
// MPSecret - MP Secret
MPSecret = "(dev)"
)
4 changes: 1 addition & 3 deletions sidecar/.goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ release:
before:
hooks:
- make clean
- go mod tidy -compat=1.21.8
- go mod download

builds:
- id: minio-operator-sidecar
Expand All @@ -31,7 +29,7 @@ builds:
binary: minio-operator-sidecar
main: ./cmd/sidecar/
ldflags:
- -s -w -X github.com/minio/operator/pkg.ReleaseTag={{.Tag}} -X github.com/minio/operator/pkg.CommitID={{.FullCommit}} -X github.com/minio/operator/sidecar/pkg.Version={{.Version}} -X github.com/minio/operator/sidecar/pkg.ShortCommitID={{.ShortCommit}} -X github.com/minio/operator/pkg.ReleaseTime={{.Date}}
- -s -w -X github.com/minio/operator/sidecar/pkg.ReleaseTag={{.Tag}} -X github.com/minio/operator/sidecar/pkg.CommitID={{.FullCommit}} -X github.com/minio/operator/sidecar/pkg.Version={{.Version}} -X github.com/minio/operator/sidecar/pkg.ShortCommitID={{.ShortCommit}} -X github.com/minio/operator/sidecar/pkg.ReleaseTime={{.Date}}
flags:
- -trimpath

Expand Down
2 changes: 1 addition & 1 deletion sidecar/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ VERSIONV ?= $(shell git describe --tags | sed 's,v,,g')
endif
TAG ?= "minio/operator-sidecar:$(VERSION)"
SHA ?= $(shell git rev-parse --short HEAD)
LDFLAGS ?= "-s -w -X github.com/minio/operator/pkg.ReleaseTag=$(VERSIONV) -X github.com/minio/operator/sidecar/pkg.Version=$(VERSION) -X github.com/minio/operator/sidecar/pkg.ShortCommitID=$(SHA)"
LDFLAGS ?= "-s -w -X github.com/minio/operator/sidecar/pkg.ReleaseTag=$(VERSIONV) -X github.com/minio/operator/sidecar/pkg.Version=$(VERSION) -X github.com/minio/operator/sidecar/pkg.ShortCommitID=$(SHA)"
GOPATH := $(shell go env GOPATH)
GOARCH := $(shell go env GOARCH)
GOOS := $(shell go env GOOS)
Expand Down
2 changes: 0 additions & 2 deletions sidecar/pkg/build-constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ var (
CommitID = "(dev)"
// ShortCommitID - first 12 characters from CommitID.
ShortCommitID = "(dev)"
// MPSecret - MP Secret
MPSecret = "(dev)"
)

0 comments on commit 39d57f3

Please sign in to comment.