Adding back Usable Capacity and Internal #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
requested review from
dvaldivia,
harshavardhana,
jiuker and
pjuarezd
harshavardhana
approved these changes
Sep 23, 2023
jiuker
approved these changes
Sep 25, 2023
|
Thank you for the reviews and approvals. I have no power to squash and merge the PR. If you find this good enough, please help me to merge when you can 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To give values to
Usable CapacityandInternalin the UI by populating back our Status in the Tenant as suggested by Harsha:adminClnt.StorageInfo(srvInfoCtx)Reasoning:
Back in Remove Log Search API and Prometheus PR we removed
metricshence leaving these fields unpopulated breaking the feature. For legacy Tenants, numbers will remain constant and for new tenants it will ben/abut with this change we can get those number back from our internal minio client.