Correcting the name of the Operator Console TLS Secret #1802
Conversation
| name: operator-console-tls | ||
| name: console-tls |
There was a problem hiding this comment.
is this a breaking change? how does it work now?
There was a problem hiding this comment.
Actually, I introduced the name of the secreted by default as console-tls in kubectl-minio on PR #1348
operator/kubectl-minio/cmd/init.go
Line 83 in 53deac5
And wrongly set the constant to operator-console-tls on the same PR
https://github.com/minio/operator/pull/1348/files#diff-0ee76ed6676e7fcf9179ac75e1d5eeb7a6e25b7bc489bb8dec243fd80e247574R40.
I fixed that discrepancy and set the expected secret name as console-tls in the PR https://github.com/minio/operator/pull/1712/files
Which test is failing? we should fix the broken test instead
|
Ok, if no longer an issue, then we should simply close it. |
In Deployment console, correcting the name of the Operator Console TLS Secret as it got changed in https://github.com/minio/operator/pull/1712/files:
and everytime is tested, manual modification is required in the deployment to use proper secret