-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support pvc deletion when need #1828
Conversation
I think this is disruptive action and should not be default option and that's taken care as part of labels. Also |
Will not delete pvcs by default. @shtripat |
Yes, if we set labels explicitly then only it would happen. Do we plan |
That happen to pipeline test. Maybe plugin are too heavy for those scenes. @shtripat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must be cautious with this, we need to make sure we document it properly such that users know that this is a disastrous thing to keep it enabled.
Co-authored-by: Harshavardhana <[email protected]>
…perator into add_field_to_delete_pvc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with this change with the caveat and documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
fix: #1803
add support pvc deletion when need
When tenant has gone. The pvc will been deleted.
That's false by default. Means will not delete the pvcs by default.