Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding an environment value to enable the ignoring of the name, accessKey and secretKey in configSecret. #2352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: adding an environment value to enable the ignoring of the name, accessKey and secretKey in configSecret. #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm/tenant/templates/tenant-configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ stringData:
export MINIO_ROOT_PASSWORD={{ .Values.tenant.configSecret.secretKey | quote }}
{{- else }}
{{- if eq .Values.tenant.environment "dev" }}
{{- if (.Values.tenant.configSecret.accessKey) }}
{{- fail "# ERROR: cannot set access-key when an existing secret is used" }}
{{- end }}
Expand All @@ -26,4 +27,5 @@ stringData:
{{- end }}
{{- end }}
{{- end }}
{{- end }}

9 changes: 9 additions & 0 deletions helm/tenant/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ tenant:
# The secret is expected to have a key named config.env containing environment variables exports.
configuration:
name: myminio-env-configuration

###
# The environment into which this tenant will be deployed.
# Valid options:
#
# environment: dev # will presume you are using the config secret in line as shown in the example below.
# environment: prod # will ignore the name, accessKey and secretKey fields if provided and enable the existingSecret value to be used.
environment: dev

###
# Root key for dynamically creating a secret for use with configuring root MinIO User
# Specify the ``name`` and then a list of environment variables.
Expand Down