Generate correctly the MinIO scrape configs for Multi Tenants scenarios #2456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Next fixes introduced:
minio-prom-additional-scrape-config
to fix this issue.prometheusagents
resources (as with Helm) when deploying the Operator usingkustomize
.A few unit tests were added to cover points (1) and (2) above.
Note: I need to port this fix to AIStor
Related Issue
Fixing issues:
#2425
#2218
Type of Change
Screenshots (if applicable e.g before/after)
Checklist
Test Steps
kind load docker-image minio/operator:noop
(loads locally built image to kind cluster)helm install minio-operator helm/operator --namespace minio-operator --create-namespace
(install Operator)helm install prometheus-operator prometheus-community/kube-prometheus-stack
(installs prometheus controllers stack and grafana controller)helm install my-tenant helm/tenant --namespace tenant-ns --create-namespace
(installs a tenant in a given namespace)helm install my-tenant helm/tenant --namespace tenant-ns --create-namespace
(installs a tenant in another given namespace)prometheusOperator: true
minio-prom-additional-scrape-config
prometheusOperator: false
so that the tenant scrape configs are removed fromminio-prom-additional-scrape-config
secret. Or add more metric endpoint with tenant configPrometheusOperatorScrapeMetricsPaths
and verify the scrape configs are added to the secret.Additional Notes / Context