Skip to content

Commit

Permalink
add missing 'err' handling for listener
Browse files Browse the repository at this point in the history
Bonus: show proper help output with no args
  • Loading branch information
harshavardhana committed Aug 19, 2024
1 parent b276ad6 commit 6e8fd5c
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ func clientTransport(ctx *cli.Context, tlsMaxVersion uint16, enableTLS bool, hos

func checkMain(ctx *cli.Context) {
if !ctx.Args().Present() {
cli.ShowCommandHelpAndExit(ctx, ctx.Command.Name, 1)
cli.ShowAppHelpAndExit(ctx, 1)
}
}

Expand Down Expand Up @@ -1152,6 +1152,9 @@ func sidekickMain(ctx *cli.Context) {
} else {
listener, err = net.Listen("tcp", addr)
}
if err != nil {
console.Fatalln(err)
}
go func() {
if err := server.Serve(listener); err != nil {
console.Fatalln(err)
Expand Down Expand Up @@ -1186,13 +1189,19 @@ func main() {
// Set system resources to maximum.
setMaxResources()

cli.HelpFlag = cli.BoolFlag{
Name: "help, h",
Usage: "show help",
}

app := cli.NewApp()
app.Name = os.Args[0]
app.HideHelpCommand = true // Hide `help, h` command, we already have `minio --help`.
app.Author = "MinIO, Inc."
app.Description = `High-Performance sidecar load-balancer`
app.UsageText = "[FLAGS] SITE1 [SITE2..]"
app.Version = version
app.Copyright = "(c) 2020-2023 MinIO, Inc."
app.Copyright = "(c) 2020-2024 MinIO, Inc."
app.Flags = []cli.Flag{
cli.StringFlag{
Name: "address, a",
Expand Down

0 comments on commit 6e8fd5c

Please sign in to comment.