Code cleanup

huisbot/Embeds.cs

@@ -424,7 +424,7 @@ private static string GetPPDifferenceText(double oldPP, double newPP)
   {
     // Calculate the difference between the two PP values. If it's less than 0.01, the PP values are the same.
     double difference = newPP - oldPP;
-    if(Math.Abs(difference) < 0.01)
+    if (Math.Abs(difference) < 0.01)
       return $"**{newPP:N2}pp**";
 
     // Otherwise return the difference string.
@@ -434,7 +434,7 @@ private static string GetPPDifferenceText(double oldPP, double newPP)
   /// <summary>
   /// A dictionary with identifiers for emojis and their corresponding <see cref="Emoji"/> object.
   /// </summary>
-  private static Dictionary<string, Emoji> _emojis = new Dictionary<string, Emoji>()
+  private static readonly Dictionary<string, Emoji> _emojis = new Dictionary<string, Emoji>()
   {
     { "XH", new Emoji("rankSSH", 1159888184600170627) },
     { "X", new Emoji("rankSS", 1159888182075207740) },

huisbot/Enums/HuisPlayerRankingSort.cs

@@ -0,0 +1,137 @@
+namespace huisbot.Enums;
+
+/// <summary>
+/// A "fake enum" representing the sorting and order options for the global player rankings returned by the Huis API.
+/// </summary>
+public class HuisPlayerRankingSort
+{
+  private static readonly HuisPlayerRankingSort[] _all = null!;
+
+  /// <summary>
+  /// Returns all the available sort options.
+  /// </summary>
+  public static HuisPlayerRankingSort[] All => new HuisPlayerRankingSort[]
+  {
+    OldPPDesc, OldPPAsc, NewPPDesc, NewPPAsc, PPDifferenceDesc, PPDifferenceAsc, AimPPDesc, AimPPAsc, TapPPDesc, TapPPAsc,
+    AccPPDesc, AccPPAsc, FLPPDesc, FLPPAsc, BonusPPDesc, BonusPPAsc, NewPPExclBonusDesc, NewPPExclBonusAsc
+  };
+
+  /// <summary>
+  /// Sorts by the old PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort OldPPDesc { get; } = new("old_pp", false, "Old PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the old PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort OldPPAsc { get; } = new("old_pp", true, "Old PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the new PP inclusive bonus of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort NewPPDesc { get; } = new("new_pp_incl_bonus", false, "New PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the new PP inclusive bonus of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort NewPPAsc { get; } = new("new_pp_incl_bonus", true, "New PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the PP difference of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort PPDifferenceDesc { get; } = new("pp_change", false, "PP Difference (Descending)");
+
+  /// <summary>
+  /// Sorts by the PP difference of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort PPDifferenceAsc { get; } = new("pp_change", true, "PP Difference (Ascending)");
+
+  /// <summary>
+  /// Sorts by the weighted Aim PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort AimPPDesc { get; } = new("weighted_aim_pp", false, "Weighted Aim PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the weighted Aim PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort AimPPAsc { get; } = new("weighted_aim_pp", true, "Weighted Aim PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the weighted Tap PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort TapPPDesc { get; } = new("weighted_tap_pp", false, "Weighted Tap PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the weighted Tap PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort TapPPAsc { get; } = new("weighted_tap_pp", true, "Weighted Tap PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the weighted Acc PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort AccPPDesc { get; } = new("weighted_acc_pp", false, "Weighted Acc PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the weighted Acc PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort AccPPAsc { get; } = new("weighted_acc_pp", true, "Weighted Acc PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the weighted FL PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort FLPPDesc { get; } = new("weighted_fl_pp", false, "Weighted FL PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the weighted FL PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort FLPPAsc { get; } = new("weighted_fl_pp", true, "Weighted FL PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the Bonus PP of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort BonusPPDesc { get; } = new("bonus_pp", false, "Bonus PP (Descending)");
+
+  /// <summary>
+  /// Sorts by the Bonus PP of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort BonusPPAsc { get; } = new("bonus_pp", true, "Bonus PP (Ascending)");
+
+  /// <summary>
+  /// Sorts by the new PP with bonus pp exclusive of the player in descending order.
+  /// </summary>
+  public static HuisPlayerRankingSort NewPPExclBonusAsc { get; } = new("new_pp_excl_bonus", false, "New PP Excl. Bonus (Descending)");
+
+  /// <summary>
+  /// Sorts by the new PP with bonus pp exclusive of the player in ascending order.
+  /// </summary>
+  public static HuisPlayerRankingSort NewPPExclBonusDesc { get; } = new("new_pp_excl_bonus", true, "New PP Excl. Bonus (Ascending)");
+
+  /// <summary>
+  /// An identifier to uniquely identify the combination of sort code and order.
+  /// </summary>
+  public string Id => $"{Code}_{(IsAscending ? "asc" : "desc")}";
+
+  /// <summary>
+  /// The code used in the Huis API parameter for this sort option.
+  /// </summary>
+  public string Code { get; }
+
+  /// <summary>
+  /// Bool whether the sort order is ascending or not.
+  /// </summary>
+  public bool IsAscending { get; }
+
+  /// <summary>
+  /// The display name of the sort option.
+  /// </summary>
+  public string DisplayName { get; }
+
+  private HuisPlayerRankingSort(string code, bool ascending, string displayName)
+  {
+    Code = code;
+    IsAscending = ascending;
+    DisplayName = displayName;
+  }
+
+  public override string ToString() => DisplayName;
+}