FIX: restore host keys after restart #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test. |
|
I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template |
|
Please copy-paste and we will verify
…On Mon, Dec 31, 2018 at 8:46 PM rbock44 ***@***.***> wrote:
I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
|
Besides, you are entitled to open a developer account on
developer.redhat.com, which grants you to download/use an instance of
RHEL
…On Mon, Dec 31, 2018 at 9:33 PM Gerard Braad ***@***.***> wrote:
Please copy-paste and we will verify
On Mon, Dec 31, 2018 at 8:46 PM rbock44 ***@***.***> wrote:
>
> I did not do the fix for redhat as I do not have a license but actually it would be just another copy past in the template
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub, or mute the thread.
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]
|
|
OK. I added the changes also to the redhat template in a second commit. Thanks for the hint on the redhat developer license. Will follow up soon on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently because of the livecd rootfs the host keys are lost. After a restart the host gets new keys. This causes problems with e.g. ssh which stores the public keys in known_hosts. Instead of messing around with ssh config it is easier to just restore the keys in case the machine was not newly created.
To keep this apart from user data I basically copied this to host-key handling.