Changes to address the broken build

- architecture tests rejected non sealed domain events - fixed
- architecture tests failed to find private parameterless constructor as required - fixed.
- mapping tests failed to detect private parameter constructors - fixed

src/Application/Features/Participants/Commands/AddConsent.cs

@@ -31,17 +31,13 @@ public async Task<Result<string>> Handle(Command request, CancellationToken canc
                 throw new NotFoundException("Cannot find participant", request.ParticipantId);
             }
 
-            var document = new Document()
-            {
-                Description = $"Consent form for {request.ParticipantId}",
-                DocumentType = DocumentType.Document,
-                IsPublic = false,
-                Title = request.UploadRequest!.FileName
-            };
+            var document = Document.Create(request.UploadRequest!.FileName,
+                $"Consent form for {request.ParticipantId}",
+                DocumentType.PDF);
 
             var result = await uploadService.UploadAsync($"{request.ParticipantId}/consent", request.UploadRequest!);
 
-            document.URL = result;
+            document.SetURL(result);
 
             participant.AddConsent(request.ConsentDate!.Value, document.Id);
 

src/Application/Features/Participants/Commands/AddRightToWork.cs

@@ -33,17 +33,14 @@ public async Task<Result<string>> Handle(Command request, CancellationToken canc
             {
                 throw new NotFoundException("Cannot find participant", request.ParticipantId);
             }
+
+            var document = Document.Create(request.UploadRequest!.FileName,
+                $"Right to work evidence for {request.ParticipantId}",
+                DocumentType.PDF);
 
-            var document = new Document()
-            {
-                Description = $"Right to work evidence for {request.ParticipantId}",
-                DocumentType = DocumentType.Document,
-                IsPublic = false,
-                Title = request.UploadRequest!.FileName
-            };
 
             var result = await uploadService.UploadAsync($"{request.ParticipantId}/rtw", request.UploadRequest!);
-            document.URL = result;
+            document.SetURL(result);
 
             participant.AddRightToWork(request.ValidFrom!.Value, request.ValidTo!.Value, document.Id);
 

src/Domain/Entities/Documents/Document.cs

@@ -1,25 +1,50 @@
 using Cfo.Cats.Domain.Common.Contracts;
 using Cfo.Cats.Domain.Common.Entities;
 using Cfo.Cats.Domain.Entities.Administration;
+using Cfo.Cats.Domain.Events;
 
 namespace Cfo.Cats.Domain.Entities.Documents;
 
 public class Document : OwnerPropertyEntity<Guid>, IMayHaveTenant, IAuditTrial
 {
-    public Document()
+    private Document()
     {
         Id = Guid.NewGuid();
     }
 
-    public string? Title { get; set; }
-    public string? Description { get; set; }
-    public string? Content { get; set; }
-    public bool IsPublic { get; set; }
-    public string? URL { get; set; }
-    public DocumentType DocumentType { get; set; } = default!;
+    private Document(string title, string description, DocumentType documentType)
+    {
+        Title = title;
+        IsPublic = false;
+        Description = description;
+        DocumentType = documentType;
+
+        AddDomainEvent(new DocumentCreatedDomainEvent(this));
+    }
+
+
+    public static Document Create(string title, string description, DocumentType documentType)
+    {
+        return new(title, description, documentType);
+    }
+
+    public Document SetURL(string url)
+    {
+        URL = url;
+        return this;
+    }
+
+    public string? Title { get; private set; }
+    public string? Description { get; private set; }
+
+    [Obsolete("We are not storing the content with the document", false)]
+    public string? Content { get; private set; }
+    public bool IsPublic { get; private set; }
+    public string? URL { get; private set; }
+    public DocumentType DocumentType { get; private set; } = default!;
     public virtual Tenant? Tenant { get; set; }
 
-    public string? TenantId {get;set;}
+    public string? TenantId {get; set;}
 }
 
 public enum DocumentType

src/Domain/Events/DocumentEvents.cs

@@ -3,6 +3,6 @@
 
 namespace Cfo.Cats.Domain.Events;
 
-public class DocumentCreatedDomainEvent(Document entity) : CreatedDomainEvent<Document>(entity);
+public sealed class DocumentCreatedDomainEvent(Document entity) : CreatedDomainEvent<Document>(entity);
 
-public class DocumentUpdatedDomainEvent(Document entity) : UpdatedDomainEvent<Document>(entity);
+public sealed class DocumentUpdatedDomainEvent(Document entity) : UpdatedDomainEvent<Document>(entity);

src/Domain/Events/RightToWorkEvents.cs

@@ -4,4 +4,4 @@
 namespace Cfo.Cats.Domain.Events;
 
 
-public class RightToWorkCreatedDomainEvent(RightToWork entity) : CreatedDomainEvent<RightToWork>(entity);
+public sealed class RightToWorkCreatedDomainEvent(RightToWork entity) : CreatedDomainEvent<RightToWork>(entity);

src/Domain/Events/TenantRenamedDomainEvent.cs

@@ -3,7 +3,7 @@
 
 namespace Cfo.Cats.Domain.Events;
 
-public class TenantRenamedDomainEvent(Tenant entity, string oldName) : UpdatedDomainEvent<Tenant>(entity)
+public sealed class TenantRenamedDomainEvent(Tenant entity, string oldName) : UpdatedDomainEvent<Tenant>(entity)
 {
     public string OldName { get; } = oldName;
 }

test/Application.UnitTests/Mappings/MappingTests.cs

@@ -51,10 +51,12 @@ public void LocationDtoShouldMapCorrectlyToLocationTypeDto()
 
     }
 
-    private object GetInstanceOf(Type type)
+    private static object GetInstanceOf(Type type)
     {
-        if (type.GetConstructor(Type.EmptyTypes) != null)
-            return Activator.CreateInstance(type);
+        // Check for a parameterless constructor, including non-public ones
+        ConstructorInfo constructor = type.GetConstructor(BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic, null, Type.EmptyTypes, null);
+        if (constructor != null)
+            return constructor.Invoke(null);
 
         // Type without parameterless constructor
         return FormatterServices.GetUninitializedObject(type);