Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create architecture test project #18

Merged
merged 28 commits into from
Jun 4, 2024
Merged

Create architecture test project #18

merged 28 commits into from
Jun 4, 2024

Conversation

carlsixsmith-moj
Copy link
Contributor

This addresses basic setup of the following

  • Creates architecture test project
  • Tests entity type configuration are named correctly
  • Some DDD best practice tests (private constructors, well named domain events etc)
  • All queries and commands should have an authroize attribute (tests break if one is found without)

@carlsixsmith-moj
git commit -m "CFODEV-469 (CFODEV-470 and CFODEV-473) create domain t…
f313900 
…est"
@carlsixsmith-moj
CFODEV-470 create blank test project for application architecture tests
5654d44
@carlsixsmith-moj
CFODEV-473 - DomainEvents should be called NOUN_DomainEvent
ae0699a
@carlsixsmith-moj
Test to confirm Entities have a private, parameterless constructor.
97e9e65 
note: tests currently fail due to needing another branch merging with this one.
@carlsixsmith-moj
Remove seeds from the initializer and add to a script instead
6579afc
@carlsixsmith-moj
CFODEV-456: Remove hardcoded database name from insert script
223f05b
@carlsixsmith-moj
Include custody locations (and their parent relationships) in the dat…
ae95558 
…a seed.
@carlsixsmith-moj
Remove the sub tenants. Let's not assume the providers are going to a…
685b976 
…utomatically require them
@carlsixsmith-moj
CFODEV-473 : fix tests after merge.
9a16fd3 
Also remove the exclusion for audittrail
@carlsixsmith-moj
CFODEV-471: make sure configurations are named correctly
21b9ffe
@carlsixsmith-moj
CFODEV-472 throw an exception if not authorize attribute exists (or w…
2a5ce9e 
…e do not explicitly allow anonymous).

Tests added to break the build if these are detected at run time.

(breaks the build as we have not yet added the authorise test to any command)
@carlsixsmith-moj
Add basic authorization attributes
79d394e
carlsixsmith-moj and others added 16 commits June 3, 2024 12:49
@carlsixsmith-moj
git commit -m "CFODEV-469 (CFODEV-470 and CFODEV-473) create domain t…
8e1d9b2 
…est"
@carlsixsmith-moj
CFODEV-470 create blank test project for application architecture tests
90b13c8
@carlsixsmith-moj
CFODEV-473 - DomainEvents should be called NOUN_DomainEvent
7354c39
@carlsixsmith-moj
Test to confirm Entities have a private, parameterless constructor.
9e19cbb 
note: tests currently fail due to needing another branch merging with this one.
@carlsixsmith-moj
Remove seeds from the initializer and add to a script instead
d841b37
@carlsixsmith-moj
CFODEV-456: Remove hardcoded database name from insert script
7c70c81
@carlsixsmith-moj
Include custody locations (and their parent relationships) in the dat…
1e323d1 
…a seed.
@carlsixsmith-moj
Remove the sub tenants. Let's not assume the providers are going to a…
552f097 
…utomatically require them
@carlsixsmith-moj
CFODEV-473 : fix tests after merge.
675436e 
Also remove the exclusion for audittrail
@carlsixsmith-moj
CFODEV-471: make sure configurations are named correctly
bb4196a
@carlsixsmith-moj
CFODEV-472 throw an exception if not authorize attribute exists (or w…
02c0e5b 
…e do not explicitly allow anonymous).

Tests added to break the build if these are detected at run time.

(breaks the build as we have not yet added the authorise test to any command)
@carlsixsmith-moj
Add basic authorization attributes
faee01a
@carlsixsmith-moj
Merge branch 'CFODEV-469-create-architecture-test-project' of github.…
8215e12 
…com:ministryofjustice/CFO-CaseAssessmentTrackingSystem into CFODEV-469-create-architecture-test-project
@carlsixsmith-moj
Merge branch 'main' into CFODEV-469-create-architecture-test-project
27d36a8
@samgibsonmoj
Merge branch 'main' into CFODEV-469-create-architecture-test-project
932f825
@carlsixsmith-moj
Merge branch 'CFODEV-469-create-architecture-test-project' of github.…
307e034 
…com:ministryofjustice/CFO-CaseAssessmentTrackingSystem into CFODEV-469-create-architecture-test-project
samgibsonmoj
samgibsonmoj approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@samgibsonmoj samgibsonmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested these architectural tests locally, and they all work as expected.

Approved!

@samgibsonmoj samgibsonmoj merged commit 95bf853 into main Jun 4, 2024
1 check passed
@carlsixsmith-moj carlsixsmith-moj deleted the CFODEV-469-create-architecture-test-project branch June 4, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samgibsonmoj samgibsonmoj samgibsonmoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlsixsmith-moj @samgibsonmoj