Cfodev 422 create database context and entities for enrolments #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olments-and-assessments' of github.com:ministryofjustice/CFO-CaseAssessmentTrackingSystem into CFODEV-422-create-database-context-and-entities-for-enrolments-and-assessments
…olments-and-assessments' of github.com:ministryofjustice/CFO-CaseAssessmentTrackingSystem into CFODEV-422-create-database-context-and-entities-for-enrolments-and-assessments
…g to serilog now in dev to stop spamming sentry.io)
…g to serilog now in dev to stop spamming sentry.io)
…olments-and-assessments' of github.com:ministryofjustice/CFO-CaseAssessmentTrackingSystem into CFODEV-422-create-database-context-and-entities-for-enrolments-and-assessments
…nts are automatically linked to new locations
…to show more information / sort correctly.
- architecture tests rejected non sealed domain events - fixed - architecture tests failed to find private parameterless constructor as required - fixed. - mapping tests failed to detect private parameter constructors - fixed
|
Tests have been fixed to remove the broken checks above. |
samgibsonmoj
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
There's a LOT of changes as part of this PR, but this was expected as part of the work done.
I've done a functional review of the changes and overall I'm happy.
There was a very minor issue with the enrolments flow, but I have raised a separate ticket in Jira to look into this.
Approved.
carlsixsmith-moj
deleted the
CFODEV-422-create-database-context-and-entities-for-enrolments-and-assessments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.