Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when setting the location of an enrolment #24

Conversation

carlsixsmith-moj
Copy link
Contributor

  • An validation error is now displayed when you don't justify alternative location
  • You cannot select use another location and then select the same location
  • hide controls when not needed
  • fix grammar on some labels.

- An validation error is now displayed when you don't justify alternative location
- You cannot select use another location and then select the same location
- hide controls when not needed
- fix grammar on some labels.
Copy link
Contributor

@samgibsonmoj samgibsonmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested changes, looks good to me.

Approved.

@samgibsonmoj samgibsonmoj merged commit 85ae720 into main Jun 26, 2024
1 check passed
@samgibsonmoj samgibsonmoj deleted the CFODEV-503-no-error-warning-shown-when-candidate-is-enrolled-at-different-location-without-reason branch June 26, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants