CFODEV-506: CATS-DMS Integration (candidate search) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f0020ab.
cats.sln
Outdated
There was a problem hiding this comment.
Well remembered. I always forget this bit!
There was a problem hiding this comment.
This can be improved by using automapper to switch between commands and DTOs
| @@ -32,35 +34,82 @@ | |||
| } | |||
| }; | |||
|
|
|||
| if (SearchResults is { Length: 0 }) | |||
| if (SearchReturnedNoCandidates()) | |||
There was a problem hiding this comment.
Loving the clean code approach. ✅
carlsixsmith-moj
previously approved these changes
Jun 27, 2024
There was a problem hiding this comment.
I approve these changes. With modifications.
@samgibsonmoj can you confirm you are ok with my changes before I merge?
|
Thanks for the review @carlsixsmith-moj. I'm happy with the changes you've made. I've made one more tiny amend to clean-up a couple of files. |
carlsixsmith-moj
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.