Added insert scripts for DMS Establishment Code and Org Code mapping … #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Cats.dbo.Contract.ContractId. updated tests with short collection inititalisation
carlsixsmith-moj
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Do not create tables with acronyms and shortened words.
The tables should be called something like
EstateCodeMappings
OrganisationCodeMappings
If we want to define them as DMS specific, we can create a DMS schema and put them in that so it would be
[dms].[EstateCodeMapping]
[dms].[OrganisationCodeMapping].
carlsixsmith-moj
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with Cats.dbo.Contract.ContractId. updated tests with short collection inititalisation.
@samgibsonmoj could you please review as you need to create schema and migrations for this.