Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove state_machine gem #5426

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Remove state_machine gem #5426

merged 1 commit into from
Mar 6, 2023

Conversation

jrmhaig
Copy link
Contributor

@jrmhaig jrmhaig commented Mar 3, 2023

What

Remove the state_machine gem.

Ticket

N/A

Why

The state_machine gem was already abandoned when it was added in 2192ec7. The supported fork, state_machines is already installed as a dependency of other gems when they were added in 7d85626.

Up to this point state_machine has not caused any problems but now it is preventing updating Ruby to version 3.2.

For reference: pluginaweek/state_machine#343

How

Remove state_machine from Gemfile and also remove the monkey patch in config/initializers/state_machine_patch.rb.

@jrmhaig
Remove state_machine gem
031af9f 
This was possibly added by accident. For reference: 2192ec7

When the state_machine gem was added it had already been unsupported for some
time and was forked as state_machines, which was added as a dependency of other
gems: 7d85626
@jrmhaig jrmhaig requested review from a team as code owners March 3, 2023 10:05
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jrmhaig jrmhaig merged commit 339d9b8 into master Mar 6, 2023
@jrmhaig jrmhaig deleted the remove_state_machine branch March 6, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpw5 mpw5 mpw5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrmhaig @mpw5