Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing production DPR data #6586

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

julialawrence
Copy link
Contributor

@julialawrence julialawrence commented Jan 23, 2025

Pull Request Objective

This piece of work is not being tracked in a ticket. It is on request from Gwion.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

This has been locally applied.

@julialawrence julialawrence requested a review from a team as a code owner January 23, 2025 08:40
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-lakeformation-external-data-digital-prisons-reporting-production

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @moj-data-platform-robot, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/lakeformation-external-data/digital-prisons-reporting-production, Workflow: Terraform, Marker: aws-analytical-platform-data-production-lakeformation-external-data-digital-prisons-reporting-production_static_analysis

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-lakeformation-external-data-digital-prisons-reporting-production

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @moj-data-platform-robot, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/lakeformation-external-data/digital-prisons-reporting-production, Workflow: Terraform, Marker: aws-analytical-platform-data-production-lakeformation-external-data-digital-prisons-reporting-production_plan

Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence merged commit b5ea11c into main Jan 23, 2025
17 checks passed
@julialawrence julialawrence deleted the feature/dpr-production-share branch January 23, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants