Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remove aws_s3_object airflow_local_settings_dev and aws_s3_object airflow_local_settings_prod #6590

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BrianEllwood
Copy link
Contributor

@BrianEllwood BrianEllwood commented Jan 23, 2025

This pull request is a bug fix for This repo and Airflow Repo conflict over desired state of Dags folder. 6419

This will remove aws_s3_object airflow_local_settings_dev and aws_s3_object airflow_local_settings_prod which are routinely removed by the Dag sync script and thus shown as in need of re creating in the terraform plan.

The terraform plan shows no changes as the code has been changed to remove the objects already removed by the sync script.

Adding override-static-analysis as warnings not related to this work

@BrianEllwood BrianEllwood requested a review from a team as a code owner January 23, 2025 15:36
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @BrianEllwood, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_static_analysis

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @BrianEllwood, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_plan

@jhpyke
Copy link
Contributor

jhpyke commented Jan 23, 2025

Could you also cleanup the underlying files that were being uploaded from the files folder? Obviously only the local_settings and not the .kube config or anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants