Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6640 athena spark workgroup fixed #6923

Merged
merged 12 commits into from
Feb 18, 2025
Merged

Conversation

jnayak-moj
Copy link
Contributor

@jnayak-moj jnayak-moj commented Feb 17, 2025

Pull Request Objective

This piece of work is being tracked in #6640 (comment) GitHub Issue.

The PR is to create a new Athena Workgroup for Athena Spark testing

A new DBT workgroup for Spark is added.
This workgroup would be used to built new python dbt models which will run on Spark3.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-athena

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jnayak-moj, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/athena, Workflow: Terraform, Marker: aws-analytical-platform-data-production-athena_static_analysis

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Terraform Component 🧱: aws-analytical-platform-data-production-athena

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jnayak-moj, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/athena, Workflow: Terraform, Marker: aws-analytical-platform-data-production-athena_plan

@jnayak-moj jnayak-moj marked this pull request as ready for review February 17, 2025 18:09
@jnayak-moj jnayak-moj requested a review from a team as a code owner February 17, 2025 18:09
@jnayak-moj jnayak-moj changed the title 6640 athena spark workgroup 6640 athena spark workgroup fixed Feb 17, 2025
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnayak-moj jnayak-moj merged commit b7246c8 into main Feb 18, 2025
21 checks passed
@jnayak-moj jnayak-moj deleted the 6640-athena-spark-workgroup branch February 18, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants