Removed commented out tests. Updated running.md to specify python 3.12

ministryofjustice · Apr 9, 2024 · 14e09ba · 14e09ba
1 parent f1f3afe
commit 14e09ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 29 deletions.
diff --git a/doc/running.md b/doc/running.md
@@ -27,8 +27,8 @@ versions of the services.
 
 ## 1. Required Dependencies
 
-The Control Panel app requires Python 3.8+ It has been confirmed to work
-with Python 3.8.12.
+The Control Panel app requires Python 3.12. It has been confirmed to work
+with Python 3.12.2.
 
 Install python dependencies with the following command:
 ```sh

diff --git a/tests/api/models/test_ip_allowlist.py b/tests/api/models/test_ip_allowlist.py
@@ -19,19 +19,6 @@ def update_aws_secrets_manager():
         yield update_aws_secrets_manager
 
 
-# def test_ip_allowlist_save_updates_aws_secrets_manager(update_aws_secrets_manager):
-#     ip_allowlist = baker.make("api.IPAllowlist", allowed_ip_ranges="123")
-#     app = baker.make("api.App", ip_allowlists=[ip_allowlist])  # noqa:F841
-#
-#     ip_allowlist.save()
-#
-#     update_aws_secrets_manager.assert_has_calls(
-#         [
-#             call({"allowed_ip_ranges": "123"}),
-#         ]
-#     )
-#
-
 def test_ip_allowlist_without_app_save_does_not_update_aws_secrets_manager(
     update_aws_secrets_manager,
 ):
@@ -42,20 +29,6 @@ def test_ip_allowlist_without_app_save_does_not_update_aws_secrets_manager(
     update_aws_secrets_manager.assert_not_called()
 
 
-# def test_ip_allowlist_delete_updates_aws_secrets_manager(update_aws_secrets_manager):
-#     ip_allowlists = [
-#         baker.make("api.IPAllowlist", allowed_ip_ranges="xyz"),
-#         baker.make("api.IPAllowlist", allowed_ip_ranges="123"),
-#     ]
-#     apps = baker.make("api.App", ip_allowlists=ip_allowlists, _quantity=2)  # noqa:F841
-#
-#     ip_allowlists[0].delete()
-#
-#     update_aws_secrets_manager.assert_has_calls(
-#         [call({"allowed_ip_ranges": "123"}), call({"allowed_ip_ranges": "123"})]
-#     )
-#
-
 def test_ip_allowlist_without_app_delete_does_not_update_aws_secrets_manager(
     update_aws_secrets_manager,
 ):