Skip to content

Commit

Permalink
Another minor fixes related to jupyter release
Browse files Browse the repository at this point in the history
  • Loading branch information
ymao2 committed Nov 30, 2022
1 parent 667b12f commit 8e439dd
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions controlpanel/api/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -701,12 +701,13 @@ def restart(self, id_token):
def is_tool_deployment(cls, metadata):
"""
Currently the logic for checking whether a deployment is for tool is based on the information we put in the
deployment yaml, the common info cross tools' helm chart is the unidler-key, we have other alternative field
for such check, e.g. whether name contains some key words, but IMO, it is too specific.
deployment yaml, the common info cross tools' helm chart is the unidler-key or unide
(somehow typo in the helm chart :(), we have other alternative field for such check, e.g. whether name contains
some key words, but IMO, it is too specific.
We may change this part if we want to refactor how the tool is released and managed.
"""
return metadata.labels.get('unidler-key') is not None
return metadata.labels.get('unidler-key') is not None or metadata.labels.get('unidle-key')

@classmethod
def get_deployments(cls, user, id_token, search_name=None, search_version=None):
Expand Down

0 comments on commit 8e439dd

Please sign in to comment.