Merge pull request #796 from ministryofjustice/ag--fix-slack-notifica…

…tions Fix creation of superusers
ministryofjustice · Feb 11, 2020 · 9e5ac4f · 9e5ac4f
2 parents d9ef133 + ec3d19f
commit 9e5ac4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/controlpanel/api/slack.py b/controlpanel/api/slack.py
@@ -17,9 +17,8 @@ def notify_superuser_created(username, by_username=None):
 
 
 def send_notification(message):
-    slack.WebClient(token=settings.SLACK['api_token']).chat_postMessage(
-        as_user=False,
-        username=f"Control Panel [{settings.ENV}]",
+    client = slack.WebClient(token=settings.SLACK['api_token'])
+    client.chat_postMessage(
         channel=settings.SLACK["channel"],
-        text=message,
+        text=f"{message} [{settings.ENV}]",
     )
diff --git a/tests/api/test_slack.py b/tests/api/test_slack.py
@@ -10,10 +10,8 @@ def message_sent(settings, slack_WebClient):
     def check_sent(message):
         slack_WebClient.assert_called_with(token=settings.SLACK["api_token"])
         slack_WebClient.return_value.chat_postMessage.assert_called_with(
-            as_user=False,
-            username=f"Control Panel [{settings.ENV}]",
             channel=settings.SLACK["channel"],
-            text=message,
+            text=f"{message} [{settings.ENV}]",
         )
         return True
     return check_sent