Fix hiding "Admin" option in datasource access (#753)

Logic was inverted and object permission not checked
ministryofjustice · Oct 2, 2019 · afb559b · afb559b
1 parent 0ed3a2a
commit afb559b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controlpanel/frontend/jinja2/includes/data-access-level-options.html b/controlpanel/frontend/jinja2/includes/data-access-level-options.html
@@ -2,7 +2,7 @@
 
 {% macro data_access_level_options(access_to_s3bucket=None, hide_admin=False) %}
   {% if not hide_admin %}
-  {% set hide_admin = request.user.has_perm('api.add_s3bucket_admin') %}
+  {% set hide_admin = not request.user.has_perm('api.add_s3bucket_admin', access_to_s3bucket.s3bucket) %}
   {% endif %}
   {{ govukRadios({
     "name": "access_level",