Fix bug in creating app role (#778)

* Fix bug in creating app role * Fix tests
ministryofjustice · Nov 19, 2019 · f15cf72 · f15cf72
1 parent 8539a2f
commit f15cf72
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/controlpanel/api/cluster.py b/controlpanel/api/cluster.py
@@ -87,7 +87,7 @@ def iam_role_name(self):
         return f"{settings.ENV}_app_{self.app.slug}"
 
     def create_iam_role(self):
-        aws.create_app_role(self.iam_role_name)
+        aws.create_app_role(self.app)
 
     def delete_iam_role(self):
         aws.delete_role(self.iam_role_name)

diff --git a/tests/api/cluster/test_app.py b/tests/api/cluster/test_app.py
@@ -12,7 +12,7 @@ def app():
 
 def test_app_create_iam_role(aws, app):
     cluster.App(app).create_iam_role()
-    aws.create_app_role.assert_called_with(app.iam_role_name)
+    aws.create_app_role.assert_called_with(app)
 
 
 def test_app_delete_iam_role(aws, app):

diff --git a/tests/api/models/test_app.py b/tests/api/models/test_app.py
@@ -31,7 +31,7 @@ def test_slug_collisions_increments():
 @pytest.mark.django_db
 def test_aws_create_role_calls_service(aws):
     app = App.objects.create(repo_url="https://example.com/repo_name")
-    aws.create_app_role.assert_called_with(app.iam_role_name)
+    aws.create_app_role.assert_called_with(app)
 
 
 @pytest.mark.django_db