-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anpl 862 configure pre commit for dev #1079
Conversation
Bumps [django-filter](https://github.com/carltongibson/django-filter) from 2.3.0 to 22.1. - [Release notes](https://github.com/carltongibson/django-filter/releases) - [Changelog](https://github.com/carltongibson/django-filter/blob/main/CHANGES.rst) - [Commits](carltongibson/django-filter@2.3.0...22.1) --- updated-dependencies: - dependency-name: django-filter dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
ANPL-862 changed max-line-length
3f6166c
to
8a2ab61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one question that I think we should resolve before merging but pre-commit is working as expected for me now 👍
…ed on s3bucket name cnovention
…age-not-refresh ANPL-1258 The bug related to status and messages on tooling env and also performance of this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given each of the checks a try and they're all working as expected, nice work @ahbensiali! 🙌
I'll approve now so you can merge when you want to, but we shouldn't each start using the hooks ourselves until we do the big formatting commit at some point in the next couple of weeks.
pre-commit added to stack
📝 Summary
As part of our code cleanup and linting efforts, pre-commit has been added using this ticket.
pre-commit is the main container that holds other tools used to clean and check our code and commits.
This PR ...
Merging this PR will have the following side-effects:
🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
📚 Documentation status