ANPL-1701 post migration clearup #1206
Conversation
| self._log_info(f"{counter}--Processing the application {app.slug}") | ||
|
|
||
| self._remove_old_auth0_clients(app, auth0_instance, apply_action=apply_action) | ||
| if "moj-analytical-services" in app.repo_url: |
There was a problem hiding this comment.
Are these apps that were marked as DO NOT MIGRATE?
There was a problem hiding this comment.
yes, that is my assumption, if the app hasn't been updated with new github org ministryofjustice which means this app hasn't been migrated over --> means they don't need to be migrated 🤓 , this way saves me extra input for this script, and less chance to miss this kind of apps
But before I run this script , will try with apply of false first
| <ul class="govuk-body"> | ||
| <li>Old repository: <a href="{{ app_migration_info["repo_url"] }}">{{ app_migration_info["repo_url"] }}</a></li> | ||
| <li>Old app name: <strong>{{ app_migration_info["app_name"] }}</strong></li> | ||
| <li>Old app URL: <a href="{{ app_migration_info["app_url"] }}">{{ app_migration_info["app_url"] }}</a></li> |
There was a problem hiding this comment.
I assume these changes will mean that the app manage page wont have links to the old app for gold scorecard? Wondering if we need to make a hardcoded exception in the meantime - not that I really want to! Depends how long we keep them on alpha, hopefully its not necessary
There was a problem hiding this comment.
No need to keep this information for gold-scorecard , the only information matter to them probably is the app_url which they know it anyway 😄 ,
|
Some minor comments just to clarify a couple of things, but otherwise looks good to me - always satisfying to see so many deletes 😄 |
This PR is to address #ANPL-1701
Merging this PR will have the following side-effects:
🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
python manage.py post_migration_clearuppython manage.py post_migration_clearup --apply📚 Documentation status